Conversation
matttbe
requested changes
Feb 23, 2026
Collaborator
matttbe
left a comment
There was a problem hiding this comment.
Thank you for this modification, and sorry for the delay.
If I'm remembering well, the original need is to increase the DLL size from 2 to 4 octets, by using the space reserved for the checksum (see Figure 2). So we don't use more option space, the packet size is not modified.
Is the goal here to reduce the overall option space by 4 octets by eventually having the SSN on 2 octets and the DLL on 2 octets, aligned?
If yes, I don't see the point to have many variations: is it not enough to have one bit describing the SSN and DLL sizes?
- both on 2 octets → we save 4 octets
- both on 4 octets → same situation as before
WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt to create a variable length DSS option that would support longer data-level length